On 3/28/22 5:56 PM, Eric W. Biederman wrote: > > Linus, > > Please pull the ptrace-cleanups-for-v5.18 tag from the git tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git ptrace-cleanups-for-v5.18 > > HEAD: dcbc65aac28360df5f5a3b613043ccc0e81da3cf ptrace: Remove duplicated include in ptrace.c > > This set of changes removes tracehook.h, moves modification of all of > the ptrace fields inside of siglock to remove races, adds a missing > permission check to ptrace.c > > The removal of tracehook.h is quite significant as it has been a major > source of confusion in recent years. Much of that confusion was > around task_work and TIF_NOTIFY_SIGNAL (which I have now decoupled > making the semantics clearer). > > For people who don't know tracehook.h is a vestiage of an attempt to > implement uprobes like functionality that was never fully merged, and > was later superseeded by uprobes when uprobes was merged. For many > years now we have been removing what tracehook functionaly a little > bit at a time. To the point where now anything left in tracehook.h is > some weird strange thing that is difficult to understand. FWIW, the notify/task_work/io_uring changes look good to me. Thanks for cleaning this up, Eric. -- Jens Axboe