On Mon, Oct 18, 2021 at 03:44:23PM +0300, Nikolay Borisov wrote: > > > On 1.09.21 г. 20:01, Omar Sandoval wrote: > > From: Omar Sandoval <osandov@xxxxxx> > > > > Now that the new support is implemented, allow the ioctl to accept the > > flags and update the version in sysfs. > > This seems like an appropriate place to bring up the discussion about > versioned streams. SO instead of adding a BTRFS_SEND_FLAG_STREAM_V2 > flag, which implies that for the next version we have to add > BTRFS_SEND_FLAG_STREAM_V3 etc. Why not generalize the flag to > BTRFS_SEND_FLAG_STREAM_VERSIONED and carve an u32 from one of the > reserved fields so that in the future we simply increment the version field? Yes, that definitely sounds better.
