On Thu 12-08-21 17:40:08, Gabriel Krisman Bertazi wrote: > Send a FS_ERROR message via fsnotify to a userspace monitoring tool > whenever a ext4 error condition is triggered. This follows the existing > error conditions in ext4, so it is hooked to the ext4_error* functions. > > It also follows the current dmesg reporting in the format. The > filesystem message is composed mostly by the string that would be > otherwise printed in dmesg. > > A new ext4 specific record format is exposed in the uapi, such that a > monitoring tool knows what to expect when listening errors of an ext4 > filesystem. > > Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxx> > Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> > --- > fs/ext4/super.c | 8 ++++++++ > 1 file changed, 8 insertions(+) <snip> > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index dfa09a277b56..b9ecd43678d7 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -897,6 +904,7 @@ void __ext4_std_error(struct super_block *sb, const char *function, > printk(KERN_CRIT "EXT4-fs error (device %s) in %s:%d: %s\n", > sb->s_id, function, line, errstr); > } > + fsnotify_sb_error(sb, sb->s_root->d_inode, errno); > > ext4_handle_error(sb, false, -errno, 0, 0, function, line); > } Does it make sense to report root inode here? ext4_std_error() gets generally used for filesystem-wide errors. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
