On Tue 27-07-21 10:16:40, Matthew Bobrowski wrote: > On Tue, Jul 27, 2021 at 09:07:28AM +1000, Matthew Bobrowski wrote: > > On Wed, Jul 21, 2021 at 10:06:56AM +0300, Amir Goldstein wrote: > > > On Wed, Jul 21, 2021 at 9:17 AM Matthew Bobrowski <repnop@xxxxxxxxxx> wrote: > > > > > > > > Hey Jan/Amir/Christian, > > > > > > > > This is an updated version of the FAN_REPORT_PIDFD series which contains > > > > the addressed nits from the previous review [0]. As per request, you can > > > > also find the draft LTP tests here [1] and man-pages update for this new > > > > API change here [2]. > > > > > > > > [0] https://lore.kernel.org/linux-fsdevel/cover.1623282854.git.repnop@xxxxxxxxxx/ > > > > [1] https://github.com/matthewbobrowski/ltp/commits/fanotify_pidfd_v2 > > > > [2] https://github.com/matthewbobrowski/man-pages/commits/fanotify_pidfd_v1 > > > > > > FWIW, those test and man page drafts look good to me :) > > > > Fantastic, thanks for the review! > > > > I will adjust the minor comments/documentation on patch 5/5 and send > > through an updated series. > > Alright, so I've fixed up the git commit message and comment in the source > code so that it's more accurate in terms of when/why FAN_NOPIDFD is > reported. > > I'm going to hold with sending through v4 until I have Jan also look peek > and poke at v3 as I want to avoid doing any unnecessary round trips. I've read through the series and I don't have any more comments besides the objection raised by Jann. I'm still considering that one... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
