On Mon, Jun 28, 2021 at 6:11 AM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Sat, Jun 19, 2021 at 02:20:02AM -0700, Peter Collingbourne wrote: > > +++ b/include/linux/mm.h > > @@ -32,6 +32,7 @@ > > #include <linux/sched.h> > > #include <linux/pgtable.h> > > #include <linux/kasan.h> > > +#include <linux/fs.h> > > No. This was because is_refpage_vma needed to access vm_file->f_op to check whether the mapping is a reference page. In v5 I've moved that part of the check into mm/refpage.c. > > +++ b/include/linux/mman.h > > @@ -2,6 +2,7 @@ > > #ifndef _LINUX_MMAN_H > > #define _LINUX_MMAN_H > > > > +#include <linux/fs.h> > > No. Okay, this one was entirely unused; removed. Peter
