Hi Geert, Thanks for your feedback! > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: 26 February 2021 08:41 > Subject: Re: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB > > Hi Fabrizio, > > On Thu, Feb 25, 2021 at 11:53 PM Fabrizio Castro > <fabrizio.castro.jz@xxxxxxxxxxx> wrote: > > Document bindings for R-Car DAB hardware accelerator, currently > > found on the r8a77990 SoC (a.k.a. R-Car E3) and on the r8a77965 > > SoC (a.k.a. R-Car M3-N). > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/misc/renesas,dab.yaml > > > +properties: > > + compatible: > > + items: > > + - enum: > > + - renesas,dab-r8a77965 # R-Car M3-N > > + - renesas,dab-r8a77990 # R-Car E3 > > Please use the recommended order for new bindings: > > renesas,r8a77965-dab > renesas,r8a77990-dab Sorry about this, will change. > > > + - const: renesas,rcar-gen3-dab # Generic fallback for R-Car Gen3 > devices > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: dab > > fck? Agreed. Thanks, Fab > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds