On Tue 16-02-21 20:02:49, Amir Goldstein wrote: > On Tue, Feb 16, 2021 at 6:27 PM Jan Kara <jack@xxxxxxx> wrote: > > Also as a small style nit, please try to stay within 80 columns. Otherwise > > the patch looks OK to me. > > > > Ever since discussions that led to: > bdc48fa11e46 checkpatch/coding-style: deprecate 80-column warning Yes, I know. > I've tuned my editor to warn on 100 columns. > I still try to refrain from long lines, but breaking a ~82 columns line > in an ugly way is something that I try to avoid. Well it depends what is in those two columns. I have my terminals exactly 80 columns wide so that I can fit as many of them on the screen as possible ;). So I don't see whatever is beyond column 80. Sometimes it is obvious enough but sometimes not and if I have to scroll, it isn't ideal. > I'll try harder to stay below 80 when it does not create ugly code, > unless you absolutely want the patches to fit in 80 columns. No, I'm not religious about 80 columns. It is really about readability. E.g. for strings, few characters beyond 80 columns does not really matter. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
