On Wed, Jan 27, 2021 at 05:10:39PM -0800, Jaegeuk Kim wrote: > > Minor thought: > How about invalidating or truncating merkel tree pages? > > Reviewed-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > Removing them from the page cache after the read, you mean? I'm not sure we can assume that users of this ioctl would want the pages to *not* be cached, any more than we could assume that for any regular read(). I think we should just leave the pages cached (like a regular read) and not do anything special. Like other pagecache pages, the kernel will evict the Merkle tree pages eventually if they aren't being accessed anymore and memory needs to be reclaimed. - Eric