On Mon, Nov 16, 2020 at 03:57:40PM -0800, Andy Lutomirski wrote: > Linux 5.10 contains this patch: > > commit 2a36ab717e8fe678d98f81c14a0b124712719840 > Author: Peter Oskolkov <posk@xxxxxxxxxx> > Date: Wed Sep 23 16:36:16 2020 -0700 > > rseq/membarrier: Add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ > > This adds an argument to an existing syscall. Before the patch, > membarrier had 2 parameters; now it has 3. Is this really okay? At > least the patch is careful and ignores the third parameter unless a > previously unused flag bit is set. So I can't see a way in which this would be problematic. I guess it might mean that strace might not be able to properly display the extra parameter if it doesn't know about the new flag, but that would also be true if we used part of a padding field for a new structure element. Flipping around the question, why would this *NOT* be okay? - Ted
