Hi Amir! On Thu 16-07-20 11:42:08, Amir Goldstein wrote: > This patch set implements the FAN_REPORT_NAME and FAN_REPORT_DIR_FID > group flags. > > I previously posted v3 of prep patch series [1] and v4 of follow up > series [2]. Since then you pick up several prep patches, so this > posting includes the rest of the prep patches along with the followup > patches with most of your comments addressed. > > Regarding the use of flag FS_EVENT_ON_CHILD and the TYPE_CHILD mark > iterator, I did not change that because I was not sure about it and it > is an internal implementation detail that we can change later. > But the discussion about it made me realize that dnotify event handler > wasn't properly adapted, so I added a patch to fix it. > > The patches are available on github [3] based on your fsnotify branch. > man-pages [4] LTP tests [5] and a demo [6] are also available. Phew! So I went through the patches. I didn't find any bug besides couple of typos I've fixed and then couple of things I've flagged at individual patches (which I've fixed up locally as well). There's just that ignore_mask handling issue outstanding. Overall I have to say I'm unhappy about the complexity of juggling with dir/inode/child, dirfh vs objfh, etc. I acknowledge that the stuff is at least well commented so I was able to grok it but still... That being said I don't have a great idea how to simplify all this so at this point I'm ok with merging things as they are but once all the functionality is in I want to have a look at how to simplify all the special cases. Anyway, for now, thanks for your persistence and work when developing this series! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
