On Mon, May 04, 2020 at 11:25:07AM -0500, Eric W. Biederman wrote: > > I am not thrilled about treating nstype as a flags fields when it is not > currently. It was my hope when I designed the interface that not > treating nstype as a flags field would save us from the problem of bits > running out. Hm, I researched the setns() syscall history before that and I didn't see that reasoning anywhere. The "nstype" arg was originally advertised on the list as "having a flags field is useful in general". > > That aside. It would be very good if the default version of setting > everything from a pidfd would set the root directory from the process it > is copying everything else from. I'm not sure I follow completely. If you specify CLONE_NEWNS then we do set the root directory with set_fs_root() in commit_nsset(). Or are you saying we should always do that independent of whether or not CLONE_NEWNS is specified? And if so could you explain why we'd want that? I'm sure I'm missing something! Christian
