On Wed 15-04-20 10:56:35, Vlastimil Babka wrote: > On 4/15/20 5:23 AM, Masami Hiramatsu wrote: > > Hi Vlastimil, > > > > On Tue, 14 Apr 2020 13:32:19 +0200 > > Vlastimil Babka <vbabka@xxxxxxx> wrote: > > > >> This series adds support for something that seems like many people always > >> wanted but nobody added it yet, so here's the ability to set sysctl parameters > >> via kernel command line options in the form of sysctl.vm.something=1 > > > > Sounds good. And would you consider to use the bootconfig instead of (or > > in addition to) the kernel command line, because it is too short to describe > > the sysctl options? > > "Instead of" - no, as that would defeat the scenario of "I just want to set this > one sysctl in grub (possibly interactively) and not update initrd for that". If > constructing bootconfig is of similar effort of loading sysctl.conf from initrd, > then I see little benefit? > > "in addition to" - sure! but I hoped that's what already happens as it seemed to > me that options from bootconfig are appended to the command line that's then > parsed by everyone else, no? But I'll try it to be sure. Completely agreed! Btw. patches look sensible to me so feel free to add Acked-by: Michal Hocko <mhocko@xxxxxxxx> -- Michal Hocko SUSE Labs
