On 2020-03-04 09:18:21 [+0100], Vlastimil Babka wrote:
> > @@ -2572,6 +2577,26 @@ int proc_dointvec(struct ctl_table *table, int write,
> > return do_proc_dointvec(table, write, buffer, lenp, ppos, NULL, NULL);
> > }
> >
> > +#ifdef CONFIG_COMPACTION
> > +static int proc_dointvec_warn_RT_change(struct ctl_table *table, int write,
> > + void __user *buffer, size_t *lenp,
> > + loff_t *ppos)
> > +{
> > + int ret, old;
> > +
> > + if (!IS_ENABLED(CONFIG_PREEMPT_RT) || !write)
> > + return proc_dointvec(table, write, buffer, lenp, ppos);
>
> Shouldn't you use her proc_dointvec_minmax() per Patch 1/2 ?
>
> > +
> > + old = *(int *)table->data;
> > + ret = proc_dointvec(table, write, buffer, lenp, ppos);
>
> And here.
Yes, thank you for noticing. It didn't make from editor to disk after
rebasing…
Sebastian
