On Wed, Feb 12, 2020 at 11:19:29AM +0800, Wu Hao wrote: > On Mon, Feb 10, 2020 at 04:34:01PM +0000, Will Deacon wrote: > > Hi, > > > > On Mon, Feb 10, 2020 at 11:47:49AM +0800, Wu Hao wrote: > > > This patch adds support for performance reporting private feature > > > for FPGA Management Engine (FME). Now it supports several different > > > performance counters, including 'basic', 'cache', 'fabric', 'vtd' > > > and 'vtd_sip'. It allows user to use standard linux tools to access > > > these performance counters. > > > > I had a quick look at this, and it mostly looks alright to me. Just a few > > high-level comments/questions: > > Hi Will > > Thanks a lot for the review! :) > > > > > - I would still prefer for the PMU drivers to live under drivers/perf/ > > Hm.. one possible way is to create a platform device, and introduce a new > platform device driver under drivers/perf/. No, do not abuse platform drivers, you have a real device, use it.
