On 1/29/2020 5:27 PM, Stefan Metzmacher wrote: >> Great, that you turned attention to that! override_creds() is already >> grabbing a ref, so it shouldn't call get_cred() there. >> So, that's a bug. >> >> It could be I'm wrong with the statement above, need to recheck all this >> code to be sure. >> >> BTW, io_req_defer_prep() may be called twice for a req, so you will >> reassign it without putting a ref. It's safer to leave NULL checks. At >> least, until I've done reworking and fixing preparation paths. > > Ok, but that would be already a bug in > "io_uring/io-wq: don't use static creds/mm assignments" > instead of logically being part of > "io_uring: support using a registered personality for commands" Right. Probably should be backported there, since it's just 2 commits before. -- Pavel Begunkov
