On Mon, Jan 20, 2020 at 03:22:03PM +0100, Oleg Nesterov wrote: > On 01/20, Christian Brauner wrote: > > > > On Mon, Jan 20, 2020 at 03:00:30PM +0100, Oleg Nesterov wrote: > > > This is probably the only patch in series I can understand ;) > > > > > > To me it looks like a good cleanup regardless, but > > > > > > On 01/17, Christian Brauner wrote: > > > > > > > > The patch just passes in the parent task_struct > > > > > > For what? "parent" is always "current", no? > > > > Yes. What exactly are you hinting at? :) Would you prefer that the > > commit message speaks of "current" instead of "parent"? > > I meant, I don't understand why did you add the new "parent" arg, > cgroup_xxx_fork() can simply use "current" ? There's no specific reason behind it. I don't care much whether it's an arg or we just grab current in each helper directly. Christian