On 10/23/19 2:02 PM, Michal Hocko wrote: > On Wed 23-10-19 13:34:23, Waiman Long wrote: > [...] >> @@ -1419,6 +1419,17 @@ static void pagetypeinfo_showfree_print(struct seq_file *m, >> } >> seq_putc(m, '\n'); >> } >> + >> + /* >> + * List total free blocks per order >> + */ >> + seq_printf(m, "Node %4d, zone %8s, total ", >> + pgdat->node_id, zone->name); >> + for (order = 0; order < MAX_ORDER; ++order) { >> + area = &(zone->free_area[order]); >> + seq_printf(m, "%6lu ", area->nr_free); >> + } >> + seq_putc(m, '\n'); > This is essentially duplicating /proc/buddyinfo. Do we really need that? Yes, you are right. As the information is available elsewhere. I am fine with dropping this. Cheers, Longman