On Mon, Oct 14, 2019 at 8:16 PM Daniel Colascione <dancol@xxxxxxxxxx> wrote: > On Mon, Oct 14, 2019 at 8:39 AM Jann Horn <jannh@xxxxxxxxxx> wrote: > > > > On Sat, Oct 12, 2019 at 9:16 PM Daniel Colascione <dancol@xxxxxxxxxx> wrote: > > > Add functions forwarding from the old names to the new ones so we > > > don't need to change any callers. > > > > This patch does more than the commit message says; it also refactors > > the body of the function. (I would've moved that refactoring over into > > patch 2, but I guess this works, too.) > > > > [...] > > > -struct file *anon_inode_getfile(const char *name, > > > - const struct file_operations *fops, > > > - void *priv, int flags) > > > +struct file *anon_inode_getfile2(const char *name, > > > + const struct file_operations *fops, > > > + void *priv, int flags, int anon_inode_flags) > > > > (AFAIK, normal kernel style is to slap a "__" prefix in front of the > > function name instead of appending a digit, but I guess it doesn't > > really matter.) > > I thought prefixing "_" was for signaling "this is an implementation > detail and you probably don't want to call it unless you know what > you're doing", not "here's a new version that does a new thing". Ah, I guess that might be true.
