On Tue, Jul 16, 2019 at 4:14 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > Small nit, but please add this as the first declaration, to keep the > "upside-down x-mas tree" look. I know some of the other functions in > this file don't follow that (which should be cleaned up some day), but > I'd like to avoid adding more that breaks the aesthetic of the code. ACK. > > + > > + if (fops) > > I think you meant "if (!fops)". Blink. Whoops! Yup.