On Wed, Jun 26, 2019 at 03:34:35PM +0800, Chao Yu wrote: > >>> + err = f2fs_convert_inline_inode(inode); > >>> + if (err) > >>> + return err; > >>> + > >>> + err = dquot_initialize(inode); > >>> + if (err) > >>> + return err; > >> > >> We can get rid of dquot_initialize() here, since f2fs_file_open() -> > >> dquot_file_open() should has initialized quota entry previously, right? > > > > We still need it because dquot_file_open() only calls dquot_initialize() if the > > file is being opened for writing. But here the file descriptor is readonly. > > I'll add a comment explaining this here and in the ext4 equivalent. > > Ah, you're right. > > f2fs_convert_inline_inode() may grab one more block during conversion, so we > need to call dquot_initialize() before inline conversion? > > Thanks, > Good point. I'll fix that here and in ext4. - Eric
