On Tue, May 7, 2019 at 12:26 PM Moritz Fischer <mdf@xxxxxxxxxx> wrote: > > On Mon, Apr 29, 2019 at 04:55:35PM +0800, Wu Hao wrote: > > This patch removes copy_to_user() code in partial reconfiguration > > ioctl, as it's useless as user never needs to read the data > > structure after ioctl. > > > > Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx> > > Signed-off-by: Wu Hao <hao.wu@xxxxxxxxx> > Acked-by: Moritz Fischer <mdf@xxxxxxxxxx> Acked-by: Alan Tull <atull@xxxxxxxxxx> Alan > > --- > > v2: clean up code split from patch 2 in v1 patchset. > > --- > > drivers/fpga/dfl-fme-pr.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c > > index d9ca955..6ec0f09 100644 > > --- a/drivers/fpga/dfl-fme-pr.c > > +++ b/drivers/fpga/dfl-fme-pr.c > > @@ -159,9 +159,6 @@ static int fme_pr(struct platform_device *pdev, unsigned long arg) > > mutex_unlock(&pdata->lock); > > free_exit: > > vfree(buf); > > - if (copy_to_user((void __user *)arg, &port_pr, minsz)) > > - return -EFAULT; > > - > > return ret; > > } > > > > -- > > 1.8.3.1 > >
