On April 18, 2019 4:26:00 PM GMT+02:00, Oleg Nesterov <oleg@xxxxxxxxxx> wrote: >On 04/18, Christian Brauner wrote: >> >> +static struct pid *pidfd_to_pid(const struct file *file) >> +{ >> + if (file->f_op == &pidfd_fops) >> + return file->private_data; >> + >> + return tgid_pidfd_to_pid(file); >> +} > >the patch looks obviously fine to me, but I have an absolutely >off-topic >question... why tgid_pidfd_to_pid() has to check d_is_dir() ? It doesn't have too; pure paranoia. Christian