On Thu, Apr 4, 2019 at 6:39 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Wed, 3 Apr 2019 17:32:49 -0700 > Matthew Garrett <matthewgarrett@xxxxxxxxxx> wrote: > > > > +static void tracefs_destroy_inode(struct inode *inode) > > +{ > > + if S_ISREG(inode->i_mode) > > Can we please put parenthesis around the condition. I know that the > macro has them, but no other place in the kernel plays such a trick. Ha, I've been spending too much time in Go lately. Fixed.