On Thu 10-01-19 19:04:35, Amir Goldstein wrote: > If group requested FAN_REPORT_FID and event has file identifier, > copy that information to user reading the event after event metadata. > > fid information is formatted as struct fanotify_event_info_fid > that includes a generic header struct fanotify_event_info_header, > so that other info types could be defined in the future using the > same header. > > metadata->event_len includes the length of the fid information. > > The fid information includes the filesystem's fsid (see statfs(2)) > followed by an NFS file handle of the file that could be passed as > an argument to open_by_handle_at(2). > > Cc: <linux-api@xxxxxxxxxxxxxxx> > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > +#define FANOTIFY_EVENT_ALIGN (sizeof(struct fanotify_event_info_header)) Here I did a small change of setting FANOTIFY_EVENT_ALIGN to plain 4. It just seems more logical to me to have the alignment specified as an absolute number rather than a size of some structure... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
