Re: [PATCH 05/18] Add io_uring IO interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Moyer <jmoyer@xxxxxxxxxx> writes:

> Hi, Jens,
>
> Jens Axboe <axboe@xxxxxxxxx> writes:
>
>> +static void io_ring_ctx_free(struct io_ring_ctx *ctx)
>> +{
>> +	destroy_workqueue(ctx->sqo_wq);
>
> You need to make sure sqo_wq is non-null before calling
> destroy_workqueue.

You also need to check for non-null sqo_files and sqo_mm.

Basically, you're tearing things down twice if setup of the context
fails in some way.

-Jeff



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux