On Mon, Nov 19, 2018 at 11:32:39AM +0100, Christian Brauner wrote: > +/** > + * sys_procfd_signal - send a signal to a process through a process file > + * descriptor > + * @fd: the file descriptor of the process > + * @sig: signal to be sent > + * @info: the signal info > + * @flags: future flags to be passed > + */ > +SYSCALL_DEFINE4(procfd_signal, int, fd, int, sig, siginfo_t __user *, info, > + int, flags) It could be considered better to use an unsigned type for the "flags" argument.