On Fri, Oct 19, 2018 at 5:35 PM, David Howells <dhowells@xxxxxxxxxx> wrote: > Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote: > >> +/* >> + * This is deprecated, and shall remain the same value in the future. To avoid >> + * confusion please use the equivalent (STATX_BASIC_STATS | STATX_BTIME) >> + * instead. >> + */ >> +#define STATX_ALL 0x00000fffU > > The comment is misleading. STATX_ALL is *not* equivalent to > STATX_BASIC_STATS | STATX_BTIME, even though it might be numerically the > same. You would need to update the comment when you add STATX_ATTRIBUTES > to mention that also. The definition of STATX_ALL is, and will remain, equivalent to STATX_BASIC_STATS | STATX_BTIME. What is misleading about this? If you feel confused by this comment, then maybe I should just drop that part. Thanks, Miklos
