Re: [PATCH v5 0/3] fanotify: introduce new event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 18, 2018 at 11:28:21AM +0200, Jan Kara wrote:
> On Wed 17-10-18 20:04:37, Matthew Bobrowski wrote:
> > Currently, the fanotify API does not provide a means for user space
> > applications to receive events when a file has been opened specifically
> > for execution. New event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM have
> > been introduced in order to provide users this capability.
> 
> OK, so these patches look mostly ready (except for a small bits I've
> commented on patch 3). 

OK, great. I can go ahead and perform the necessary updates. These are
minor though, so I'm not sure whether it's appropriate to actually send
through and entire new patch series that include these changes? To be fair
I'm not entirely sure how you're meant to really submit through these
minor updates based on previous reviews...

> How about the LTP test to actually test them? Once that exists, I can
> test the patches and merge them into my tree...

Yes, I'm working on them at the moment. I've got some time coming up this
weekend, so I hope to have them ready for you by then. It's a little
fiddly when it comes to incorporating the exec events into previous tests.
The way they're currently written doesn't really allow for them to be
somewhat extensible in my opinion. I've written a new test in a completely
separate test file, which is easy enough; however I think that these new
event types should most definitely be part of perviously written tests
i.e. fanotify03 for FAN_OPEN_EXEC_PERM. I've discussed this with Amir and
he also agrees.

-- 
Matthew Bobrowski <mbobrowski@xxxxxxxxxxxxxx>



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux