On Oct 17, 2018, at 12:24 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > I'm trying to implement statx for fuse and ran into the following issues: > > - Need a STATX_ATTRIBUTES bit, so that userspace can explicitly ask > for stx_attribute; otherwise if querying has non-zero cost, then > filesystem cannot do it without regressing performance. Seems reasonable. > - STATX_ALL definition is unclear, can this change, or is it fixed? > If it's the former, than that's a backward compatibility nightmare. > If it's the latter, then what's the point? The value can change over time. It is intended to reflect the current state of affairs at the time the userspace program and kernel are compiled. The value sent from userspace lets the kernel know what fields are in the userspace struct, so it doesn't try to set fields that aren't there. The value in the kernel allows masking off new fields from userspace that it doesn't understand. > - STATX_ATIME is cleared from stx_mask on SB_RDONLY, and on NFS it is > also cleared on MNT_NOATIME, but not on MNT_RDONLY. We need some sort > of guideline in the documentation about what constitutes > "unsupported": does atime become unsupported because filesystem is > remounted r/o? If so, why isn't this case handled consistently in the > VFS and filesystems? Strange. I'd think that if userspace is requesting atime, it should get an atime value. The fact that the kernel is not updating atime due to mount options just means that atime might be old. That doesn't mean (IMHO) that atime doesn't exist. > - What about fields that are not cached when statx() is called with > AT_STATX_DONT_SYNC? E.g. stx_btime is supported by the filesystem, > but getting it requires a roundtrip to the server. Requesting > STATX_BTIME in the mask and adding AT_STATX_DONT_SYNC to the flags > means the filesystem has to decide which it will honor. My feeling > is that it should honor AT_STATX_DONT_SYNC and clear STATX_BTIME in > stx_mask. Documentation has no word about this case. The btime value shouldn't change over the lifetime of a file, so DONT_SYNC shouldn't have any effect on its validity? I think DONT_SYNC applies to values like size, blocks, mtime, ctime that may change rapidly over the lifetime of the file, so a totally up-to-date value is not needed from the server in that case. Cheers, Andreas
Attachment:
signature.asc
Description: Message signed with OpenPGP
