On Fri, Jul 6, 2018 at 12:23 PM Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote: > > For -rc, I would favor the following simpler approach. Or I could even > just use get_user() instead. Thoughts ? Please just use "get_user()". In fact, we should be thinking seriosly about just removing __get_user() entirely. It's wrong. It optimizes the wrong thing entirely. It _used_ to be that the range check was noticeable, and it really isn't any more. These days the expensive parts are the SMAP costs, and both get_user() and __get_user() have those, except get_user() is safer and doesn't waste I$ on inlining the code to disable and re-enable SMAP. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html