On Mon, 28 May 2018, Herbert Xu wrote:
On Mon, May 28, 2018 at 06:12:09AM -0700, Davidlohr Bueso wrote:
Well, I don't really _want_ them; nor does the ipc code which already
does a WARN_ON() (but that goes away in future patches). What I want
is to get rid of the return path. So I don't really care if we convert
them to WARN or remove them altogether. Would you be happy with the
later?
It has nothing to do with the error return path. Assuming you
remove the allocation failure path, then this error path can never
trigger for *your* use-case.
Why would this be triggered by any use case if the developer setup the
params correctly...? I don't see the point of not getting rid of the
EINVAL or wrapping around warning around it. Ultimately it would be
good to just have rhashtable_init() return void.
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
