On Thu, 24 May 2018, Linus Torvalds wrote:
On Thu, May 24, 2018 at 2:28 PM Davidlohr Bueso <dave@xxxxxxxxxxxx> wrote:
10 files changed, 79 insertions(+), 86 deletions(-)
I certainly can't complain about this small code removal, but I think if we
did the kvmalloc_node() cleanup, we'd be able to get rid of even more.
For example, bucket_table_alloc() does that
if (gfp != GFP_KERNEL)
tbl = kzalloc(size, gfp | __GFP_NOWARN | __GFP_NORETRY);
else
tbl = kvzalloc(size, gfp);
purely due to the kvalloc_node() oddity. Wouldn't it be nice to just write
it as
tbl = kvzalloc(size, gfp);
knowing that the whole point of all the kv*alloc*() functions is to "just
do the right thing given size, gpf mask, and ease of allocation".
Yes this makes a lot of sense. I'll see about adding it on top.
Thanks,
Davidlohr
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
