Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- On Mar 28, 2018, at 3:40 PM, rostedt rostedt@xxxxxxxxxxx wrote:

> On Wed, 28 Mar 2018 12:38:48 -0700
> Alexei Starovoitov <ast@xxxxxx> wrote:
> 
>> On 3/28/18 12:34 PM, Steven Rostedt wrote:
>> > On Wed, 28 Mar 2018 12:05:37 -0700
>> > Alexei Starovoitov <ast@xxxxxxxxxx> wrote:
>> >  
>> >> +++ b/include/linux/tracepoint-defs.h
>> >> @@ -35,4 +35,10 @@ struct tracepoint {
>> >>  	struct tracepoint_func __rcu *funcs;
>> >>  };
>> >>
>> >> +struct bpf_raw_event_map {
>> >> +	struct tracepoint	*tp;
>> >> +	void			*bpf_func;
>> >> +	u32			num_args;
>> >> +} __aligned(32);
>> >> +
>> >
>> > If you prefer v7, I'm fine with that. For cache issues, I can pull out
>> > the funcs from the tracepoint structure like I posted.
>> 
>> I very much prefer to land this v8 as-is and optimize later.
>> 
>> I still have bpfilter/microkernel patches to finish which were
>> practically ready two weeks ago and got delayed but this set.
> 
> Then by all means, you have my Ack. We can optimize later.
> 
> For the whole series... (v7 or v8)
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

I'm fine with either v7 or v8 as well.

Thanks,

Mathieu

> 
> Thanks!
> 
> -- Steve

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux