Re: [RFC PATCH for 4.17 02/21] rseq: Introduce restartable sequences system call (v12)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 28, 2018 at 02:29:46PM +0200, Peter Zijlstra wrote:
> > +static int rseq_get_rseq_cs(struct task_struct *t,
> > +			    unsigned long *start_ip,
> > +			    unsigned long *post_commit_offset,
> > +			    unsigned long *abort_ip,
> > +			    uint32_t *cs_flags)
> > +{

> 
> > +
> > +	*cs_flags = rseq_cs.flags;
> > +	*start_ip = rseq_cs.start_ip;
> > +	*post_commit_offset = rseq_cs.post_commit_offset;
> > +	*abort_ip = rseq_cs.abort_ip;
> 
> Then this becomes a straight struct assignment.

I initially suggested passing a structure instead of many arguments, but
then recondidered, mostly because it will be inlined (due to having only
the one caller) anyway. Still, maybe a struct will work better, I dunno.


--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux