On Thu, Mar 22, 2018 at 1:48 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> OK, but instead of changing it to pass by reference, why not just pass
> the value. That is:
>
> static void xen_set_pte_atomic(pte_t *ptep, pte_t pte)
> {
> - trace_xen_mmu_set_pte_atomic(ptep, pte);
> + trace_xen_mmu_set_pte_atomic(ptep, native_pte_val(pte));
> set_64bit((u64 *)ptep, native_pte_val(pte));
> }
That looks simple and clean, and makes sense since the function itself
then uses that value anyway.
Certainly simpler than my monster define.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
