On Wed 2017-12-13 14:16:40, Michal Hocko wrote: > On Wed 13-12-17 14:09:00, Pavel Machek wrote: > > On Wed 2017-12-13 14:04:58, Michal Hocko wrote: > > > On Wed 13-12-17 13:55:40, Pavel Machek wrote: > > > > On Wed 2017-12-13 10:31:10, Michal Hocko wrote: > > > > > From: John Hubbard <jhubbard@xxxxxxxxxx> > > > > > > > > > > -- Expand the documentation to discuss the hazards in > > > > > enough detail to allow avoiding them. > > > > > > > > > > -- Mention the upcoming MAP_FIXED_SAFE flag. > > > > > > > > Pretty map everyone agreed MAP_FIXED_SAFE was a bad > > > > name. MAP_FIXED_NOREPLACE (IIRC) was best replacement. > > > > > > Please read http://lkml.kernel.org/r/20171213092550.2774-1-mhocko@xxxxxxxxxx > > > > Please fix your patches according to the feedback... > > > > NACCKED-by: Pavel Machek <pavel@xxxxxx> > > Good luck pursuing this further then. I am not going to spend time on > naming bikeheds. I have more pressing stuff to work on. You selected stupid name for a flag. Everyone and their dog agrees with that. There's even consensus on better name (and everyone agrees it is better than .._SAFE). Of course, we could have debate if it is NOREPLACE or NOREMOVE or ... and that would be bikeshed. This was just poor naming on your part. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
