Thnaks for point Best Regards, Oleksandr Shamray > -----Original Message----- > From: Philippe Ombredanne [mailto:pombredanne@xxxxxxxx] > Sent: Thursday, November 30, 2017 10:21 AM > To: Kun Yi <kunyi@xxxxxxxxxx> > Cc: Oleksandr Shamray <oleksandrs@xxxxxxxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx>; arnd@xxxxxxxx; system-sw-low-level <system- > sw-low-level@xxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; jiri@xxxxxxxxxxx; > Vadim Pasternak <vadimp@xxxxxxxxxxxx>; linux-api@xxxxxxxxxxxxxxx; > OpenBMC Maillist <openbmc@xxxxxxxxxxxxxxxx>; LKML <linux- > kernel@xxxxxxxxxxxxxxx>; openocd-devel-owner@xxxxxxxxxxxxxxxxxxxxx; > mec@xxxxxxxxx; Jiri Pirko <jiri@xxxxxxxxxxxx>; robh+dt@xxxxxxxxxx; linux- > serial@xxxxxxxxxxxxxxx; tklauser@xxxxxxxxxx; Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx > families JTAG master driver > > On Wed, Nov 29, 2017 at 11:51 PM, Kun Yi <kunyi@xxxxxxxxxx> wrote: > > On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray > > <oleksandrs@xxxxxxxxxxxx> wrote: > [] > >> diff --git a/drivers/jtag/jtag-aspeed.c b/drivers/jtag/jtag-aspeed.c > >> new file mode 100644 index 0000000..a6e2417 > >> --- /dev/null > >> +++ b/drivers/jtag/jtag-aspeed.c > >> @@ -0,0 +1,782 @@ > >> +/* > >> + * drivers/jtag/aspeed-jtag.c > >> + * > >> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved. > >> + * Copyright (c) 2017 Oleksandr Shamray <oleksandrs@xxxxxxxxxxxx> > >> + * > >> + * Released under the GPLv2 only. > >> + * SPDX-License-Identifier: GPL-2.0 > >> + */ > > I think the SPDX id should be on the first line as requested by Linus and > documented by Thomas (tglx) and Greg (greg-kh). And it should use // > comments, e.g: > > // SPDX-License-Identifier: GPL-2.0 > > See the threads discussing all these. > > > -- > Cordially > Philippe Ombredanne ��.n��������+%������w��{.n�����{����* jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
