On Sat, Jun 17, 2017 at 05:09:44AM +0100, Al Viro wrote:
> On Thu, Jun 15, 2017 at 10:59:56AM -0500, Goldwyn Rodrigues wrote:
> > static inline int kiocb_set_rw_flags(struct kiocb *ki, int flags)
> > {
> > - if (unlikely(flags & ~(RWF_HIPRI | RWF_DSYNC | RWF_SYNC)))
> > + if (unlikely(flags & ~(RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT)))
>
> Minor nit: that calls for something like
> if (unlikely(flags & ~RWF_ALL)
> > return -EOPNOTSUPP;
>
> with corresponding definition.
Possibly. Note _ALL is not correct - at least RWF_HIPRI is explicitly
defined a shint that can be ignored.
Maybe RWF_SUPPORTED.
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
