Tested-by: Bamvor Jian Zhang <bamvor.zhangjian@xxxxxxxxxx> On 9 February 2017 at 16:56, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: > Both these rules incorrectly use $< (first prerequisite) rather than > $^ (all prerequisites), meaning they don't work if we're using more than > one .S file as input. Switch them to using $^. > > They also don't include $(CPPFLAGS) and other variables used in the > default rules, which breaks targets that require those. Fix that by > using the builtin $(COMPILE.S) and $(LINK.S) rules. > > Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT") > Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > --- > tools/testing/selftests/lib.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 98841c54763a..ce96d80ad64f 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -54,9 +54,9 @@ $(OUTPUT)/%:%.c > $(LINK.c) $^ $(LDLIBS) -o $@ > > $(OUTPUT)/%.o:%.S > - $(CC) $(ASFLAGS) -c $< -o $@ > + $(COMPILE.S) $^ -o $@ > > $(OUTPUT)/%:%.S > - $(CC) $(ASFLAGS) $< -o $@ > + $(LINK.S) $^ $(LDLIBS) -o $@ > > .PHONY: run_tests all clean install emit_tests > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-api" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html