Re: [PATCH v3 02/10] ima: use %pU to output UUID in printable format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-04-05 at 16:56 +0300, Andy Shevchenko wrote:
> Instead of open coded variant re-use extension what vsprintf.c provides us for
> ages.

trivia:

> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
[]
> @@ -1012,17 +1012,7 @@ int ima_policy_show(struct seq_file *m, void *v)
>  	}
>  
>  	if (entry->flags & IMA_FSUUID) {
> -		seq_puts(m, "fsuuid=");
> -		for (i = 0; i < ARRAY_SIZE(entry->fsuuid); ++i) {
> -			switch (i) {
> -			case 4:
> -			case 6:
> -			case 8:
> -			case 10:
> -				seq_puts(m, "-");
> -			}
> -			seq_printf(m, "%x", entry->fsuuid[i]);
> -		}
> +		seq_printf(m, "fsuuid=%pU", entry->fsuuid);
>  		seq_puts(m, " ");
>  	}

Maybe combine the printf and puts

		seq_printf(m, "fsuuid=%pU ", entry->fsuuid);

--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux