I really wanted to Ack this time, but you know I am nitpicking again :(
On 22-03-16, 16:18, Shilpasri G Bhat wrote:
> static int powernv_cpufreq_cpu_init(struct cpufreq_policy *policy)
> {
> - int base, i;
> + int base, i, ret;
>
> base = cpu_first_thread_sibling(policy->cpu);
>
> for (i = 0; i < threads_per_core; i++)
> cpumask_set_cpu(base + i, policy->cpus);
>
> + if (!policy->driver_data) {
Declare ret here, as it is going to be used only within the if block.
> + ret = sysfs_create_group(&policy->kobj, &throttle_attr_grp);
> + if (ret) {
> + pr_info("Failed to create throttle stats directory for cpu %d\n",
> + policy->cpu);
> + return ret;
> + }
> + /*
> + * policy->driver_data is used as a flag for one-time
> + * creation of throttle sysfs files.
> + */
> + policy->driver_data = (void *)policy;
This is far better then the ugly solution I suggested on our private chat :),
but you should drop (void *) typecast. Its not required.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
