On February 27, 2016 10:35:28 AM PST, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: >On Sat, Feb 27, 2016 at 6:58 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> >wrote: >> >> Paul's patches have the following structure: >> >> struct thread_local_abi { >> union { >> struct { >> u32 cpu_id; >> u32 seq; >> }; >> u64 cpu_seq; >> }; >> unsigned long post_commit_ip; >> }; > >Please don't do "unsigned long" in ABI structures any more. > >Make it u64, and make sure it is 64-bit aligned (which it would be in >this case). Make it so that we don't have to have separate compat >paths. > > Linus Yes, if we have to do compat crap for this entire new ABI path I think I'll scream. -- Sent from my Android device with K-9 Mail. Please excuse brevity and formatting. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html