On Mon, Jan 25, 2016 at 04:44:53PM +0100, Petr Mladek wrote: > +struct kthread_worker * > +create_kthread_worker_on_cpu(int cpu, const char namefmt[]) > +{ > + if (cpu < 0 || cpu > num_possible_cpus()) > + return ERR_PTR(-EINVAL); Comparing cpu ID to num_possible_cpus() doesn't make any sense. It should either be testing against cpu_possible_mask or testing against nr_cpu_ids. Does this test need to be in this function at all? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html