On 12/09/2015 03:50 PM, Brian Norris wrote: > request_firmware() failures currently won't get reported at all (the > error code is discarded). What's more, we get confusing messages, like: > > # echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request > [ 8280.311856] test_firmware: loading 'notafile' > [ 8280.317042] test_firmware: load of 'notafile' failed: -2 > [ 8280.322445] test_firmware: loaded: 0 > # echo $? > 0 > > Report the failures via write() errors, and don't say we "loaded" > anything. > > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> > Acked-by: Kees Cook <keescook@xxxxxxxxxxxx> Thanks for fixing it. Applied to linux-kselftest next for 4.5-rc1. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
