Hello Everybody, Sorry for the long delay. I wanted to resurrect this thread. Andy suggested to create a new syscall instead of using netlink interface. > Would it make more sense to have a new syscall instead? You could > even still use nlattr formatting for the syscall results. I tried to implement it to understand how it looks like. Here is my version: https://github.com/avagin/linux-task-diag/blob/task_diag_syscall/kernel/task_diag.c#L665 I could not invent a better interfaces for it than using netlink messages as arguments. I know it looks weird. I could not say that I understood why a new system call is better than using a netlink socket, so I tried to solve the problem which were mentioned for the netlink interface. The magor question was how to support pid and user namespaces in task_diag. I think I found a good and logical solution. As for pidns, we can use scm credentials, which is connected to each socket message. They contain requestor’s pid and we can get a pid namespace from it. In this case, we get a good feature to specify a pid namespace without entering into it. For that, an user need to specify any process from this pidns in an scm message. As for credentials, we can get them from file->f_cred. In this case we are able to create a socket and decrease permissions of the current process, but the socket will work as before. It’s the common behaviour for file descriptors. As before, I incline to use the netlink interface for task_diag: * Netlink is designed for such type of workloads. It allows to expand the interface and save backward compatibility. It allows to generates packets with a different set of parameters. * If we use a file descriptor, we can create it and decrease capabilities of the current process. It's a good feature which will be unavailable if we decide to create a system call. * task_stat is a bad example, because a few problems were not solved in it. I’m going to send the next version of the task_diag patches in a few days. Any comments are welcome. Here is the git repo with the current version: https://github.com/avagin/linux-task-diag/commits/master Thanks, Andrew On Mon, Jul 06, 2015 at 11:47:01AM +0300, Andrey Vagin wrote: > Currently we use the proc file system, where all information are > presented in text files, what is convenient for humans. But if we need > to get information about processes from code (e.g. in C), the procfs > doesn't look so cool. > > From code we would prefer to get information in binary format and to be > able to specify which information and for which tasks are required. Here > is a new interface with all these features, which is called task_diag. > In addition it's much faster than procfs. > > task_diag is based on netlink sockets and looks like socket-diag, which > is used to get information about sockets. > > A request is described by the task_diag_pid structure: > > struct task_diag_pid { > __u64 show_flags; /* specify which information are required */ > __u64 dump_stratagy; /* specify a group of processes */ > > __u32 pid; > }; > > dump_stratagy specifies a group of processes: > /* per-process strategies */ > TASK_DIAG_DUMP_CHILDREN - all children > TASK_DIAG_DUMP_THREAD - all threads > TASK_DIAG_DUMP_ONE - one process > /* system wide strategies (the pid fiel is ignored) */ > TASK_DIAG_DUMP_ALL - all processes > TASK_DIAG_DUMP_ALL_THREAD - all threads > > show_flags specifies which information are required. > If we set the TASK_DIAG_SHOW_BASE flag, the response message will > contain the TASK_DIAG_BASE attribute which is described by the > task_diag_base structure. > > struct task_diag_base { > __u32 tgid; > __u32 pid; > __u32 ppid; > __u32 tpid; > __u32 sid; > __u32 pgid; > __u8 state; > char comm[TASK_DIAG_COMM_LEN]; > }; > > In future, it can be extended by optional attributes. The request > describes which task properties are required and for which processes > they are required for. > > A response can be divided into a few netlink packets if the NETLINK_DUMP > has been set in a request. Each task is described by a message. Each > message contains the TASK_DIAG_PID attribute and optional attributes > which have been requested (show_flags). A message can be divided into a > few parts if it doesn’t fit into a current netlink packet. In this case, > the first message in the next packet contains the same PID and > attributes which doesn’t fit into the previous message. > > The task diag is much faster than the proc file system. We don't need to > create a new file descriptor for each task. We need to send a request > and get a response. It allows to get information for a few tasks in one > request-response iteration. > > As for security, task_diag always works as procfs with hidepid = 2 (highest > level of security). > > I have compared performance of procfs and task-diag for the > "ps ax -o pid,ppid" command. > > A test stand contains 30108 processes. > $ ps ax -o pid,ppid | wc -l > 30108 > > $ time ps ax -o pid,ppid > /dev/null > > real 0m0.836s > user 0m0.238s > sys 0m0.583s > > Read /proc/PID/stat for each task > $ time ./task_proc_all > /dev/null > > real 0m0.258s > user 0m0.019s > sys 0m0.232s > > $ time ./task_diag_all > /dev/null > > real 0m0.052s > user 0m0.013s > sys 0m0.036s > > And here are statistics on syscalls which were called by each > command. > > $ perf trace -s -o log -- ./task_proc_all > /dev/null > > Summary of events: > > task_proc_all (30781), 180785 events, 100.0%, 0.000 msec > > syscall calls min avg max stddev > (msec) (msec) (msec) (%) > --------------- -------- --------- --------- --------- ------ > read 30111 0.000 0.013 0.107 0.21% > write 1 0.008 0.008 0.008 0.00% > open 30111 0.007 0.012 0.145 0.24% > close 30112 0.004 0.011 0.110 0.20% > fstat 3 0.009 0.013 0.016 16.15% > mmap 8 0.011 0.020 0.027 11.24% > mprotect 4 0.019 0.023 0.028 8.33% > munmap 1 0.026 0.026 0.026 0.00% > brk 8 0.007 0.015 0.024 11.94% > ioctl 1 0.007 0.007 0.007 0.00% > access 1 0.019 0.019 0.019 0.00% > execve 1 0.000 0.000 0.000 0.00% > getdents 29 0.008 1.010 2.215 8.88% > arch_prctl 1 0.016 0.016 0.016 0.00% > openat 1 0.021 0.021 0.021 0.00% > > > $ perf trace -s -o log -- ./task_diag_all > /dev/null > Summary of events: > > task_diag_all (30762), 717 events, 98.9%, 0.000 msec > > syscall calls min avg max stddev > (msec) (msec) (msec) (%) > --------------- -------- --------- --------- --------- ------ > read 2 0.000 0.008 0.016 100.00% > write 197 0.008 0.019 0.041 3.00% > open 2 0.023 0.029 0.036 22.45% > close 3 0.010 0.012 0.014 11.34% > fstat 3 0.012 0.044 0.106 70.52% > mmap 8 0.014 0.031 0.054 18.88% > mprotect 4 0.016 0.023 0.027 10.93% > munmap 1 0.022 0.022 0.022 0.00% > brk 1 0.040 0.040 0.040 0.00% > ioctl 1 0.011 0.011 0.011 0.00% > access 1 0.032 0.032 0.032 0.00% > getpid 1 0.012 0.012 0.012 0.00% > socket 1 0.032 0.032 0.032 0.00% > sendto 2 0.032 0.095 0.157 65.77% > recvfrom 129 0.009 0.235 0.418 2.45% > bind 1 0.018 0.018 0.018 0.00% > execve 1 0.000 0.000 0.000 0.00% > arch_prctl 1 0.012 0.012 0.012 0.00% > > You can find the test program from this experiment in tools/test/selftest/taskdiag. > > The idea of this functionality was suggested by Pavel Emelyanov > (xemul@), when he found that operations with /proc forms a significant > part of a checkpointing time. > > Ten years ago there was attempt to add a netlink interface to access to /proc > information: > http://lwn.net/Articles/99600/ > > git repo: https://github.com/avagin/linux-task-diag > > Changes from the first version: > > David Ahern implemented all required functionality to use task_diag in > perf. > > Bellow you can find his results how it affects performance. > > Using the fork test command: > > 10,000 processes; 10k proc with 5 threads = 50,000 tasks > > reading /proc: 11.3 sec > > task_diag: 2.2 sec > > > > @7,440 tasks, reading /proc is at 0.77 sec and task_diag at 0.096 > > > > 128 instances of sepcjbb, 80,000+ tasks: > > reading /proc: 32.1 sec > > task_diag: 3.9 sec > > > > So overall much snappier startup times. > > Many thanks to David Ahern for the help with improving task_diag. > > Cc: Oleg Nesterov <oleg@xxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Cyrill Gorcunov <gorcunov@xxxxxxxxxx> > Cc: Pavel Emelyanov <xemul@xxxxxxxxxxxxx> > Cc: Roger Luethi <rl@xxxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > Cc: David Ahern <dsahern@xxxxxxxxx> > Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx> > Cc: Pavel Odintsov <pavel.odintsov@xxxxxxxxx> > Signed-off-by: Andrey Vagin <avagin@xxxxxxxxxx> > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
