On 10/20/2015 05:10 AM, Paul Osmialowski wrote: > Hi Shuah, > > Thanks for your comments, > > On Mon, 19 Oct 2015, Shuah Khan wrote: > >>> --- a/tools/testing/selftests/Makefile >>> +++ b/tools/testing/selftests/Makefile >>> @@ -7,6 +7,7 @@ TARGETS += ftrace >>> TARGETS += futex >>> TARGETS += kcmp >>> TARGETS += kdbus >> >> Doesn't look like this patch is based on linux-kselftest next >> or Linus's latest. Please base your work on either one of the >> above. Please make sure "make kselftest" from top level Makefile >> doesn't break. >> >>> +TARGETS += kmsg > > Any guidelines what such test should be implemented (apart from use of > kselftest.h API)? If kselftest.h works well for reporting errors, please use it. No requirement on that. The one important thing to remember is new test shouldn't break "make kselftest" run and install tool kselftest_install.sh > >>> +kmsg-test: $(OBJS) >>> + $(CC) $(CFLAGS) $^ $(LDLIBS) -o $@ >>> + >>> +run_tests: >>> + ./kmsg-test --tap >> >> What does --tap do? Is this a longform option? >> I don't see it in usage() >> > > Should be removed - I copy-pasted parts of kdbus selftests Makefile not > noticing that. > > Best regards, > Paul > -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
