Hello, On Wed, Jul 29, 2015 at 01:23:54PM +0200, Petr Mladek wrote: > My plan is to make the API cleaner and hide struct kthread_worker > definition into kthread.c. It would prevent anyone doing any hacks > with it. BTW, we do the same with struct workqueue_struct. I think obsessive attachment to cleanliness tends to worse code in general like simple several liner wrappers which don't do anything other than increasing interface surface and obscuring what's going on. Let's please take a reasonable trade-off. It shouldn't be nasty but we don't want to be paying unnecessary complexity for perfect purity either. > Another possibility would be to add helper function to get the > associated task struct but this might cause inconsistencies when > the worker is restarted. A kthread_worker would be instantiated on the create call and released on destroy and the caller is natrually expected to synchronize creation and destruction against all other operations. Nothing seems complicated or subtle to me. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
