On 07/06, Andrey Vagin wrote: > > -static struct pid * > -get_children_pid(struct inode *inode, struct pid *pid_prev, loff_t pos) > +static struct task_struct * > +task_next_child(struct task_struct *parent, struct task_struct *prev, unsigned int pos) > { I won't really argue, just a question... So this patch changes it to accept/return task_struct rather pid. Why? it is better to get/put "struct pid" only, not the whole task_struct. If another caller want task_struct, the necessary conversion is simple. But again, I won't argue if you think this will complicate the non-proc users of this helper. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html