On Sat, May 30, 2015 at 05:37:56PM +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> drm/drm_mode.h:472:2: error: unknown type name ‘uint32_t’
It's even more or less required by the coding style. Chapter 5
(typedefs) says:
(e) Types safe for use in userspace.
In certain structures which are visible to userspace, we cannot
require C99 types and cannot use the 'u32' form above. Thus, we
use __u32 and similar types in all structures which are shared
with userspace.
So this is probably an improvement in any case.
Thanks,
Frans
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
> ---
> include/uapi/drm/drm_mode.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index dbeba94..03e4d75 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -508,14 +508,14 @@ struct drm_mode_crtc_page_flip {
>
> /* create a dumb scanout buffer */
> struct drm_mode_create_dumb {
> - uint32_t height;
> - uint32_t width;
> - uint32_t bpp;
> - uint32_t flags;
> + __u32 height;
> + __u32 width;
> + __u32 bpp;
> + __u32 flags;
> /* handle, pitch, size will be returned */
> - uint32_t handle;
> - uint32_t pitch;
> - uint64_t size;
> + __u32 handle;
> + __u32 pitch;
> + __u64 size;
> };
>
> /* set up for mmap of a dumb scanout buffer */
> @@ -532,7 +532,7 @@ struct drm_mode_map_dumb {
> };
>
> struct drm_mode_destroy_dumb {
> - uint32_t handle;
> + __u32 handle;
> };
>
> /* page-flip flags are valid, plus: */
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
