Hi Vladimir, Thanks for the review, and sorry for the late reply. 2015-04-09 15:04 GMT+02:00 Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>: > Hi Maxime, > > On 07.04.2015 19:30, Maxime Coquelin wrote: >> This drivers adds support to the STM32 USART controller, which is a >> standard serial driver. >> >> Tested-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> >> Reviewed-by: Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx> >> --- >> drivers/tty/serial/Kconfig | 17 + >> drivers/tty/serial/Makefile | 1 + >> drivers/tty/serial/stm32-usart.c | 735 +++++++++++++++++++++++++++++++++++++++ >> include/uapi/linux/serial_core.h | 3 + >> 4 files changed, 756 insertions(+) >> create mode 100644 drivers/tty/serial/stm32-usart.c > > [snip] > >> +static void stm32_console_write(struct console *co, const char *s, unsigned cnt) >> +{ >> + struct uart_port *port = &stm32_ports[co->index].port; >> + unsigned long flags; >> + u32 old_cr1, new_cr1; >> + int locked = 1; >> + >> + if (oops_in_progress) { >> + locked = spin_trylock_irqsave(&port->lock, flags); >> + } else { >> + locked = 1; ID > > locked = 1 is done from the declaration. Right, I will fix this in next version > > Also do you want to add "if (port->sysrq) locked = 0;" check? Yes, that makes sense. It will be also in v7. > >> + spin_lock_irqsave(&port->lock, flags); >> + } >> + > > [snip] > > Everything else is fine from point of view. > > Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx> Regards, Maxime > > -- > With best wishes, > Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html